Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: nil check panic #75

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Fix: nil check panic #75

merged 1 commit into from
Apr 10, 2023

Conversation

Somefive
Copy link
Collaborator

Fixes #74

@Somefive Somefive requested a review from FogDong as a code owner April 10, 2023 03:14
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (e020ce3) 86.27% compared to head (8091d34) 86.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   86.27%   86.31%   +0.03%     
==========================================
  Files          73       74       +1     
  Lines        3272     3280       +8     
==========================================
+ Hits         2823     2831       +8     
  Misses        344      344              
  Partials      105      105              
Flag Coverage Δ
unit-test 86.31% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cue/cuex/compiler.go 83.19% <100.00%> (ø)
util/runtime/nil.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FogDong FogDong merged commit 3c5837b into kubevela:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withExtraData cannot process struct value
2 participants