Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gatedClient #91

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Remove gatedClient #91

merged 1 commit into from
Jul 31, 2023

Conversation

chivalryq
Copy link
Member

gatedClient has been fully replaced by remoteClusterClient

Signed-off-by: qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@chivalryq chivalryq requested a review from Somefive as a code owner July 31, 2023 07:38
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (2cef0c3) 87.78% compared to head (ed920e2) 87.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   87.78%   87.85%   +0.07%     
==========================================
  Files          81       81              
  Lines        3871     3803      -68     
==========================================
- Hits         3398     3341      -57     
+ Misses        359      350       -9     
+ Partials      114      112       -2     
Flag Coverage Δ
unit-test 87.85% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
multicluster/client.go 90.32% <100.00%> (+4.46%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to double check if it will affect the use kubevela-controller.

@chivalryq chivalryq merged commit 325c22e into main Jul 31, 2023
8 checks passed
@chivalryq chivalryq deleted the chore/remove-gatedClient branch July 31, 2023 08:43
FogDong added a commit to FogDong/pkg that referenced this pull request Apr 21, 2024
@FogDong
Copy link
Member

FogDong commented Apr 21, 2024

Well it did affect kubevela controller...

FogDong added a commit to FogDong/pkg that referenced this pull request Apr 21, 2024
FogDong added a commit that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants