Fix(lint): Increase minimum cyclomatic complexity and exclude 'packag…

…e-comments' & 'exported' lint errors

Signed-off-by: motilayo <joshuaagboola@live.ca>

.golangci.yml

@@ -44,7 +44,7 @@ linters-settings:
 
   gocyclo:
     # minimal code complexity to report, 30 by default (but we recommend 10-20)
-    min-complexity: 30
+    min-complexity: 32
 
   maligned:
     # print struct with more effective memory layout or not, false by default
@@ -179,6 +179,14 @@ issues:
       linters:
         - revive
 
+    - text: "package-comments:"
+      linters:
+        - revive
+
+    - text: "exported:"
+      linters:
+        - revive
+
   # Independently from option `exclude` we use default exclude patterns,
   # it can be disabled by this option. To list all
   # excluded by default patterns execute `golangci-lint run --help`.

controllers/configuration_controller.go

@@ -548,7 +548,6 @@ func (r *ConfigurationReconciler) preCheck(ctx context.Context, configuration *v
 			}
 			meta.JobEnv = jobEnv
 		}
-
 		if err := meta.getCredentials(ctx, k8sClient, p); err != nil {
 			return err
 		}
@@ -557,9 +556,9 @@ func (r *ConfigurationReconciler) preCheck(ctx context.Context, configuration *v
 	if meta.GitCredentialsReference != nil {
 		gitCreds, err := tfcfg.GetGitCredentialsFromConfiguration(ctx, k8sClient, meta.GitCredentialsReference.Namespace, meta.GitCredentialsReference.Name)
 		if gitCreds == nil {
-			msg := "Git credentials Secret not found"
+			msg := "git credentials Secret not found"
 			if err != nil {
-				msg = fmt.Sprintf("git credentials Secret not found: %s", err)
+				msg = err.Error()
 			}
 			if updateStatusErr := meta.updateApplyStatus(ctx, k8sClient, types.Authorizing, msg); updateStatusErr != nil {
 				return errors.Wrap(updateStatusErr, msg)