Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix get TF Outputs type err #262

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

leason00
Copy link
Member

@leason00 leason00 commented Mar 4, 2022

Fix kubevela/kubevela#3363

Signed-off-by: leason leasonlover@gmail.com

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #262 (17f2e63) into master (7760da7) will decrease coverage by 0.37%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   77.77%   77.40%   -0.38%     
==========================================
  Files          19       19              
  Lines        1188     1208      +20     
==========================================
+ Hits          924      935      +11     
- Misses        193      200       +7     
- Partials       71       73       +2     
Flag Coverage Δ
unit 77.40% <57.14%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/configuration_controller.go 69.09% <57.14%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7760da7...17f2e63. Read the comment docs.

Copy link
Collaborator

@zzxwill zzxwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Signed-off-by: lisen <lisen@youzan.com>
@zzxwill zzxwill merged commit 355a7d9 into kubevela:master Mar 8, 2022
leason00 added a commit to leason00/community that referenced this pull request May 24, 2022
I'm a contributor from YouZan that uses Kubevela to manage apps and terraform-controller to manage resources.

I have been actively contributing to KubeVela cloud resource, and the three pr have been merged

kubevela/terraform-controller#307
kubevela/terraform-controller#300
kubevela/terraform-controller#262
leason00 added a commit to leason00/community that referenced this pull request May 24, 2022
I'm a contributor from YouZan that uses Kubevela to manage apps and terraform-controller to manage resources.

I have been actively contributing to KubeVela cloud resource, and the three pr have been merged

kubevela/terraform-controller#307
kubevela/terraform-controller#300
kubevela/terraform-controller#262

Signed-off-by: lisen <lisen@youzan.com>
wonderflow pushed a commit to kubevela/community that referenced this pull request May 24, 2022
I'm a contributor from YouZan that uses Kubevela to manage apps and terraform-controller to manage resources.

I have been actively contributing to KubeVela cloud resource, and the three pr have been merged

kubevela/terraform-controller#307
kubevela/terraform-controller#300
kubevela/terraform-controller#262

Signed-off-by: lisen <lisen@youzan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants