Fix some bugs of backup_restore tool
#333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: loheagn <loheagn@icloud.com>
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 75.13% 76.58% +1.45%
==========================================
Files 24 24
Lines 1701 1764 +63
==========================================
+ Hits 1278 1351 +73
+ Misses 344 335 -9
+ Partials 79 78 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
chivalryq
reviewed
Aug 8, 2022
Comment on lines
117
to
119
| if backendNS != "" { | ||
| goto end | ||
| } |
There was a problem hiding this comment.
The logic isn't that complex. Using If Else is enough
| log.Printf("WARN: get terraform-controller deployment in the vela-system namesapce failed, %v", err) | ||
| return "" | ||
| } | ||
| envs := deployment.Spec.Template.Spec.Containers[0].Env |
There was a problem hiding this comment.
Better if we check the container's name?
Signed-off-by: loheagn <loheagn@icloud.com>
…ESPACE` env from terraform-controller deployment Signed-off-by: loheagn <loheagn@icloud.com>
chivalryq
reviewed
Aug 9, 2022
Signed-off-by: loheagn <loheagn@icloud.com>
chivalryq
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backup_restoretool failedTERRAFORM_BACKEND_NAMESPACEenv from the terraform-controller deployment if user doesn't set it in the local environmentSigned-off-by: loheagn loheagn@icloud.com