Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rollback delete resource logic #341

Merged
merged 2 commits into from Aug 16, 2022

Conversation

chivalryq
Copy link
Member

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@leason00
Copy link
Member

LGTM

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #341 (1f49401) into master (5d81c7b) will increase coverage by 2.72%.
The diff coverage is 80.51%.

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   76.58%   79.31%   +2.72%     
==========================================
  Files          24       23       -1     
  Lines        1764     1750      -14     
==========================================
+ Hits         1351     1388      +37     
+ Misses        335      278      -57     
- Partials       78       84       +6     
Flag Coverage Δ
e2e ?
unit 79.31% <80.51%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/configuration/configuration.go 95.40% <ø> (+2.33%) ⬆️
controllers/configuration/backend/kubernetes.go 76.10% <72.72%> (-6.51%) ⬇️
controllers/configuration_controller.go 77.35% <82.95%> (-0.36%) ⬇️
controllers/configuration/backend/backend.go 89.58% <100.00%> (+0.22%) ⬆️
controllers/provider/credentials.go 92.63% <100.00%> (ø)
controllers/provider/ucloud.go 100.00% <100.00%> (ø)
controllers/terraform/status.go 77.41% <100.00%> (ø)
e2e/normal/regression.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Somefive Somefive merged commit b224570 into kubevela:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants