Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: split TFConfigurationMeta to single package #379

Merged
merged 5 commits into from Sep 22, 2023

Conversation

chivalryq
Copy link
Member

Signed-off-by: Qiaozp qiaozhongpei.qzp@alibaba-inc.com

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 71.90% and project coverage change: -6.40% ⚠️

Comparison is base (3a96f68) 79.31% compared to head (283c9d4) 72.92%.
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   79.31%   72.92%   -6.40%     
==========================================
  Files          23       27       +4     
  Lines        1750     2068     +318     
==========================================
+ Hits         1388     1508     +120     
- Misses        278      471     +193     
- Partials       84       89       +5     
Flag Coverage Δ
e2e 0.00% <0.00%> (∅)
unit 75.51% <71.99%> (-3.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
controllers/configuration/configuration.go 92.22% <0.00%> (-3.19%) ⬇️
controllers/process/git.go 0.00% <0.00%> (ø)
controllers/provider/credentials.go 92.63% <ø> (ø)
controllers/terraform/status.go 77.41% <ø> (ø)
e2e/normal/regression.go 0.00% <0.00%> (ø)
controllers/configuration_controller.go 66.91% <49.25%> (-10.45%) ⬇️
controllers/process/process.go 75.68% <75.68%> (ø)
controllers/process/meta.go 76.92% <76.92%> (ø)
controllers/util/rbac.go 89.65% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rollback persistent volume to three

Signed-off-by: qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@chivalryq chivalryq merged commit eded6d0 into kubevela:master Sep 22, 2023
8 of 10 checks passed
@chivalryq chivalryq deleted the refactor/split-meta branch September 22, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant