Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Info about all the supported actions for the custom triggers in the manual triggers page. #834

Closed
NeerajGartia21 opened this issue Jun 4, 2023 · 2 comments · Fixed by #836
Closed

[Feature] Add Info about all the supported actions for the custom triggers in the manual triggers page. #834

NeerajGartia21 opened this issue Jun 4, 2023 · 2 comments · Fixed by #836
Assignees
@NeerajGartia21

Comments

@NeerajGartia21
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Since the approve, terminate and rollback actions are added for the custom triggers, we can add a sample request body for each of the actions in the manual triggers page.

manual-trigger-8361fea9230d5f56d649dca15a33f1db

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@chivalryq
Copy link
Member

chivalryq commented Jun 5, 2023 •
edited
Loading

Looks good, here's a reference from Xata.
image
And in this case I think horizontal tabs are better.

@NeerajGartia21
Copy link
Collaborator Author

Yeah, horizontal tabs will be best suitable.

Also I'm not able to add labels to the issue. Is it restricted?

@NeerajGartia21 NeerajGartia21 mentioned this issue Jun 6, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeerajGartia21 NeerajGartia21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: add info about other custom triggers NeerajGartia21/velaux
2 participants
@chivalryq @NeerajGartia21