Feat: add info about other custom triggers #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/velaux-ui/src/pages/ApplicationConfig/components/TriggerList/index.tsx
Fixed
Show fixed
Hide fixed
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
==========================================
+ Coverage 60.91% 61.04% +0.12%
==========================================
Files 110 110
Lines 19406 19406
==========================================
+ Hits 11822 11846 +24
+ Misses 6122 6103 -19
+ Partials 1462 1457 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
packages/velaux-ui/src/pages/ApplicationConfig/components/TriggerList/index.tsx
Fixed
Show fixed
Hide fixed
chivalryq
reviewed
Jun 7, 2023
packages/velaux-ui/src/pages/ApplicationConfig/components/TriggerList/index.tsx
Outdated
Show resolved
Hide resolved
|
The function looks good to me. I think it will be better to optimize some style.
|
|
Sure, I will try to implement these styles. |
| action: 'rollback', | ||
| step : 'suspend' | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
|
Done @chivalryq ! |
chivalryq
approved these changes
Jun 8, 2023
|
Can you fix the static check CI? https://github.com/kubevela/velaux/actions/runs/5199367843/jobs/9376667695?pr=836 |
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
NeerajGartia21
force-pushed
the
triggers-info
branch
from
90c8e96
to
eb38dfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds curl commands for all types of custom triggers.
Screen.Recording.2023-06-07.at.8.24.15.AM.mov
Fixes #834
I have:
yarn lintto ensure the frontend changes are ready for review.make reviewableto ensure the server changes are ready for review.backport release-x.ylabels to auto-backport this PR if necessary.Special notes for your reviewer