Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add the processing of rollback status to the version list #696

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Fix: Add the processing of rollback status to the version list #696

merged 1 commit into from
Mar 14, 2023

Conversation

jiaxiaolei007
Copy link
Contributor

@jiaxiaolei007 jiaxiaolei007 commented Mar 13, 2023

Description of your changes

Fixes #
Add the processing of rollback status to the version list

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

I don't know whether this rollback state needs a corresponding dot style. If so, what color should it be?I think light blue is good

@jiaxiaolei007 jiaxiaolei007 changed the title fix: Add the processing of rollback status to the version list Fix: Add the processing of rollback status to the version list Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -28.05 ⚠️

Comparison is base (443dfb8) 60.18% compared to head (3cd1198) 32.13%.

❗ Current head 3cd1198 differs from pull request most recent head 1092aaf. Consider uploading reports for the commit 1092aaf to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #696       +/-   ##
===========================================
- Coverage   60.18%   32.13%   -28.05%     
===========================================
  Files          94       78       -16     
  Lines       17595    16538     -1057     
===========================================
- Hits        10590     5315     -5275     
- Misses       5697    10430     +4733     
+ Partials     1308      793      -515     
Flag Coverage Δ
apiserver-unittests 32.13% <ø> (+0.03%) ⬆️
server-e2e-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 84 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG
Copy link
Collaborator

@jiaxiaolei007 Please sign DCO.

Signed-off-by: jiaxiaolei <584736476@qq.com>
@jiaxiaolei007
Copy link
Contributor Author

jiaxiaolei007 commented Mar 14, 2023

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants