Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support get secret from project config for helm chart #698

Merged
merged 7 commits into from
Mar 30, 2023

Conversation

caiqi1111
Copy link
Contributor

Description of your changes

Support get secret from project config for helm chart.

im

im

-->

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 55.55% and project coverage change: -0.10 ⚠️

Comparison is base (c312e3f) 60.34% compared to head (c086e1f) 60.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   60.34%   60.24%   -0.10%     
==========================================
  Files          94       99       +5     
  Lines       17622    17994     +372     
==========================================
+ Hits        10634    10841     +207     
- Misses       5679     5811     +132     
- Partials     1309     1342      +33     
Flag Coverage Δ
apiserver-unittests 32.22% <40.00%> (+0.12%) ⬆️
server-e2e-tests 49.58% <17.77%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/interfaces/api/repository.go 47.96% <46.66%> (+0.50%) ⬆️
pkg/server/domain/service/helm.go 49.20% <60.00%> (+0.13%) ⬆️

... and 19 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/server/domain/service/helm.go Fixed Show fixed Hide fixed
pkg/server/domain/service/helm.go Fixed Show fixed Hide fixed
pkg/server/domain/service/helm.go Fixed Show fixed Hide fixed
pkg/server/domain/service/helm.go Fixed Show fixed Hide fixed
pkg/server/domain/service/helm.go Fixed Show fixed Hide fixed
@barnettZQG
Copy link
Collaborator

@caiqi1111 Let's change the frontend code to fix this issue completely. The related code path packages/velaux-ui/src/extends/Helm*

@caiqi1111
Copy link
Contributor Author

caiqi1111 commented Mar 27, 2023

@barnettZQG I have changed the frontend code. please review again

@barnettZQG
Copy link
Collaborator

@caiqi1111 Did you rebase the latest code?

@caiqi1111
Copy link
Contributor Author

@barnettZQG I use ”git pull“ get the latest code and solve the conflict, did not use git rebase

@barnettZQG
Copy link
Collaborator

@caiqi1111 Please rebase the latest code.

Signed-off-by: caiqi <caiqi_yewu@cmss.chinamobile.com>
Signed-off-by: caiqi <caiqi_yewu@cmss.chinamobile.com>
Signed-off-by: caiqi <caiqi_yewu@cmss.chinamobile.com>
Signed-off-by: caiqi <caiqi_yewu@cmss.chinamobile.com>
Signed-off-by: caiqi <caiqi_yewu@cmss.chinamobile.com>
Signed-off-by: caiqi <caiqi_yewu@cmss.chinamobile.com>
Signed-off-by: caiqi <caiqi_yewu@cmss.chinamobile.com>
@caiqi1111
Copy link
Contributor Author

caiqi1111 commented Mar 28, 2023

@barnettZQG I have rebased the latest code now.

@jiaxiaolei007
Copy link
Contributor

LGTM

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit 4ca9085 into kubevela:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants