-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: force reset password when first time login #716
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
===========================================
+ Coverage 50.13% 61.09% +10.95%
===========================================
Files 98 99 +1
Lines 17974 18081 +107
===========================================
+ Hits 9012 11047 +2035
+ Misses 7815 5692 -2123
- Partials 1147 1342 +195
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 29 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please enhance your code.
83a7f45
to
f4cbca2
Compare
packages/velaux-ui/src/layout/Header/components/EditPlatFormUserDialog/index.tsx
Outdated
Show resolved
Hide resolved
263d3f8
to
f03d771
Compare
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> Add test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> add initialize admin twice test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> use es6 braces code format Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> lint style and remove init admin Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> fix tests Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> remove the legacy admin init logic Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> remove all model.DefaultAdminUserName in non-test file Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
4323c84
to
cb0aec5
Compare
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
b8c3912
to
9ec7b81
Compare
remove addon enable process before e2e test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
b9626a7
to
970a242
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Force reset password when first time login Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> Add test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> add initialize admin twice test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> use es6 braces code format Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> lint style and remove init admin Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> fix tests Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> remove the legacy admin init logic Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> remove all model.DefaultAdminUserName in non-test file Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * remove model.DefaultAdminUserName in test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * tidy code Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * reviewable Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * Fix unit test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * fix unit test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * Fix auth ut Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * fix dex login test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * fix broken configure admin ut Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * fix auth ut Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * reviewable Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * add debug log remove addon enable process before e2e test Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> * remove debug info Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> --------- Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com> Signed-off-by: liyanfang <liyanfang@cmss.chinamobile.com>
Description of your changes
When first time login, force user to reset the admin password.
First time login
After init admin
![image](https://user-images.githubusercontent.com/47812250/227092947-9dbf79c7-4b13-402a-9788-bc29d8f526b7.png)
Fixes #
I have:
yarn lint
to ensure the frontend changes are ready for review.make reviewable
to ensure the server changes are ready for review.backport release-x.y
labels to auto-backport this PR if necessary.Special notes for your reviewer