Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: refactor workflow status syncer with informer #723

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Mar 27, 2023

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@FogDong FogDong force-pushed the refactor-sync branch 3 times, most recently from a59193b to 95f7d2d Compare March 29, 2023 02:44
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 63.68% and project coverage change: +0.33 🎉

Comparison is base (93ecac2) 60.34% compared to head (b1f5d32) 60.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
+ Coverage   60.34%   60.67%   +0.33%     
==========================================
  Files          99       98       -1     
  Lines       17966    17975       +9     
==========================================
+ Hits        10841    10907      +66     
+ Misses       5788     5731      -57     
  Partials     1337     1337              
Flag Coverage Δ
apiserver-unittests 32.19% <44.27%> (-0.03%) ⬇️
server-e2e-tests 50.05% <63.18%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/event/sync/cr2ux.go 52.13% <39.24%> (+0.45%) ⬆️
pkg/server/domain/service/workflow.go 57.25% <76.41%> (+4.82%) ⬆️
pkg/server/event/event.go 100.00% <100.00%> (ø)
pkg/server/event/sync/cache.go 71.92% <100.00%> (+3.92%) ⬆️
pkg/server/event/sync/worker.go 77.61% <100.00%> (+0.68%) ⬆️

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FogDong FogDong force-pushed the refactor-sync branch 4 times, most recently from 0e42b86 to 92adfce Compare March 29, 2023 11:07
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@barnettZQG barnettZQG merged commit d2582ed into kubevela:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants