Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: List application api by label #727

Merged
merged 6 commits into from
Mar 29, 2023

Conversation

basuotian
Copy link
Contributor

Description of your changes

Fixes: List application api by label

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Basuotian <basuoluomiu@gmail.com>
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (93ecac2) 60.34% compared to head (0194569) 60.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
+ Coverage   60.34%   60.39%   +0.05%     
==========================================
  Files          99       99              
  Lines       17966    17974       +8     
==========================================
+ Hits        10841    10855      +14     
+ Misses       5788     5782       -6     
  Partials     1337     1337              
Flag Coverage Δ
apiserver-unittests 32.20% <0.00%> (-0.02%) ⬇️
server-e2e-tests 49.76% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/domain/service/application.go 58.75% <100.00%> (+0.20%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
@basuotian basuotian force-pushed the fix/apiserver-labelselector-api branch from 66cd218 to f379613 Compare March 28, 2023 07:47
@basuotian basuotian closed this Mar 28, 2023
@basuotian basuotian force-pushed the fix/apiserver-labelselector-api branch from f379613 to 93ecac2 Compare March 28, 2023 07:47
@basuotian basuotian reopened this Mar 28, 2023
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit d9b9919 into kubevela:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants