Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: yarn2 config in vscode guide #738

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Fix: yarn2 config in vscode guide #738

merged 1 commit into from
Mar 30, 2023

Conversation

basuotian
Copy link
Contributor

Description of your changes

Fixes yarn2 config in vscode guide

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@basuotian
fix config yarn2 in vscode
239d9bf 
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
barnettZQG
barnettZQG approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit 30988cf into kubevela:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnettZQG barnettZQG barnettZQG approved these changes

@wonderflow wonderflow Awaiting requested review from wonderflow wonderflow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basuotian @barnettZQG