Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add button loading style #741

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

chivalryq
Copy link
Member

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@chivalryq chivalryq changed the title Add button loading style Feat: add button loading style Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (bceaad7) 61.08% compared to head (df4c942) 61.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   61.08%   61.11%   +0.03%     
==========================================
  Files          99       99              
  Lines       18081    18081              
==========================================
+ Hits        11045    11051       +6     
+ Misses       5693     5689       -4     
+ Partials     1343     1341       -2     
Flag Coverage Δ
apiserver-unittests 32.57% <ø> (+0.01%) ⬆️
server-e2e-tests 49.99% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@chivalryq chivalryq merged commit 1dec098 into kubevela:main Apr 4, 2023
mujinhuakai pushed a commit to mujinhuakai/velaux that referenced this pull request Apr 8, 2023
Signed-off-by: liyanfang <liyanfang@cmss.chinamobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants