Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Translation component is not default #750

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

barnettZQG
Copy link
Collaborator

@barnettZQG barnettZQG commented Apr 10, 2023

Description of your changes

Fixes an issue come from #744

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@barnettZQG barnettZQG marked this pull request as ready for review April 10, 2023 07:45
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +27.94 🎉

Comparison is base (9bbb0b9) 33.13% compared to head (da536db) 61.07%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #750       +/-   ##
===========================================
+ Coverage   33.13%   61.07%   +27.94%     
===========================================
  Files          87      106       +19     
  Lines       17477    18589     +1112     
===========================================
+ Hits         5791    11354     +5563     
+ Misses      10822     5842     -4980     
- Partials      864     1393      +529     
Flag Coverage Δ
apiserver-unittests 33.16% <ø> (+0.03%) ⬆️
server-e2e-tests 49.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 91 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@barnettZQG barnettZQG merged commit 49a3a03 into kubevela:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant