Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix sync when restarting the application #775

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Apr 15, 2023

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Patch coverage: 61.01% and project coverage change: +0.02 🎉

Comparison is base (118ea99) 61.09% compared to head (a11eea3) 61.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   61.09%   61.12%   +0.02%     
==========================================
  Files         107      107              
  Lines       18986    19010      +24     
==========================================
+ Hits        11600    11620      +20     
+ Misses       5962     5952      -10     
- Partials     1424     1438      +14     
Flag Coverage Δ
apiserver-unittests 33.60% <16.94%> (-0.12%) ⬇️
server-e2e-tests 49.90% <57.62%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/domain/service/workflow.go 58.13% <51.06%> (-0.52%) ⬇️
pkg/server/event/sync/cr2ux.go 52.50% <100.00%> (-3.06%) ⬇️

... and 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit ac9493f into kubevela:main Apr 16, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants