Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: mongodb adds data model to set update time #808

Merged
merged 1 commit into from
May 9, 2023

Conversation

nuclearwu
Copy link
Contributor

@nuclearwu nuclearwu commented May 5, 2023

Signed-off-by: wuzhongjian wuzhongjian_yewu@cmss.chinamobile.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@nuclearwu
Copy link
Contributor Author

nuclearwu commented May 5, 2023

@barnettZQG @chivalryq @FogDong @wangyikewxgm @yangsoon please review

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (2509508) 61.17% compared to head (ed5ea1b) 61.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   61.17%   61.21%   +0.03%     
==========================================
  Files         109      109              
  Lines       19129    19130       +1     
==========================================
+ Hits        11703    11711       +8     
+ Misses       5980     5975       -5     
+ Partials     1446     1444       -2     
Flag Coverage Δ
apiserver-unittests 33.70% <100.00%> (-0.12%) ⬇️
server-e2e-tests 49.92% <0.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...server/infrastructure/datastore/mongodb/mongodb.go 60.55% <100.00%> (+0.18%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nuclearwu nuclearwu changed the title Fix: mogodb adds data model to set update time Fix: mongodb adds data model to set update time May 5, 2023
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There seems to have some issue with CI. Could you add some minor changes in another commit and push again?

@nuclearwu
Copy link
Contributor Author

nuclearwu commented May 8, 2023

There seems to have some issue with CI. Could you add some minor changes in another commit and push again

@chivalryq could you run CI again, I read that the error reported by CI seems to have nothing to do with my code
image

@chivalryq
Copy link
Member

@nuclearwu Sorry I'm not sure yarn install would fail given no front-end file is modified. I'm gonna try in another PR to check the problem.

@nuclearwu
Copy link
Contributor Author

@nuclearwu Sorry I'm not sure yarn install would fail given no front-end file is modified. I'm gonna try in another PR to check the problem.

OK.

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
@nuclearwu
Copy link
Contributor Author

@barnettZQG @chivalryq It is necessary to back port, right?

@chivalryq chivalryq merged commit 55380e2 into kubevela:main May 9, 2023
16 checks passed
@github-actions
Copy link

github-actions bot commented May 9, 2023

Successfully created backport PR #813 for release-1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants