Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: list user projects panic #810

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

chivalryq
Copy link
Member

Description of your changes

  1. fix panic:

image

  1. shorten the indent

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.15 ⚠️

Comparison is base (2509508) 61.17% compared to head (d580595) 61.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
- Coverage   61.17%   61.03%   -0.15%     
==========================================
  Files         109      109              
  Lines       19129    19134       +5     
==========================================
- Hits        11703    11678      -25     
- Misses       5980     6003      +23     
- Partials     1446     1453       +7     
Flag Coverage Δ
apiserver-unittests 33.76% <60.00%> (-0.06%) ⬇️
server-e2e-tests 49.67% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/domain/service/user.go 54.15% <60.00%> (-1.21%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit 872f162 into kubevela:main May 9, 2023
14 of 16 checks passed
@github-actions
Copy link

github-actions bot commented May 9, 2023

Successfully created backport PR #812 for release-1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants