Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Modify advanced parameters to align left #817

Merged
merged 2 commits into from
May 18, 2023
Merged

Fix: Modify advanced parameters to align left #817

merged 2 commits into from
May 18, 2023

Conversation

jiaxiaolei007
Copy link
Contributor

Description of your changes

Fixes #
In creating an application, advanced parameters should be left aligned:

image

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: jiaxiaolei <584736476@qq.com>
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06 🎉

Comparison is base (55380e2) 61.06% compared to head (a0943f2) 61.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
+ Coverage   61.06%   61.12%   +0.06%     
==========================================
  Files         109      109              
  Lines       19135    19143       +8     
==========================================
+ Hits        11684    11701      +17     
+ Misses       6000     5991       -9     
  Partials     1451     1451              
Flag Coverage Δ
apiserver-unittests 33.68% <ø> (-0.04%) ⬇️
server-e2e-tests 49.78% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chivalryq chivalryq changed the title Fix:Modify advanced parameters to align left Fix: Modify advanced parameters to align left May 10, 2023
Signed-off-by: jiaxiaolei <584736476@qq.com>
Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chivalryq chivalryq merged commit 3622218 into kubevela:main May 18, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants