Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: application table view crash when app have no labels #842

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

chivalryq
Copy link
Member

Description of your changes

Fixes #823

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -11.79 ⚠️

Comparison is base (2931e13) 60.91% compared to head (5d73893) 49.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #842       +/-   ##
===========================================
- Coverage   60.91%   49.12%   -11.79%     
===========================================
  Files         110      110               
  Lines       19406    19406               
===========================================
- Hits        11821     9534     -2287     
- Misses       6122     8621     +2499     
+ Partials     1463     1251      -212     
Flag Coverage Δ
apiserver-unittests ?
server-e2e-tests 49.12% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@barnettZQG barnettZQG merged commit 04aa7e9 into kubevela:main Jun 13, 2023
15 of 16 checks passed
@github-actions
Copy link

Successfully created backport PR #843 for release-1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An unexpected error happened when open velaux
3 participants