Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: upgrade kubevela and pkg #848

Merged
merged 9 commits into from
Jun 26, 2023

Conversation

chivalryq
Copy link
Member

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 23.95% and project coverage change: -0.81 ⚠️

Comparison is base (7a81518) 60.97% compared to head (89939c1) 60.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   60.97%   60.16%   -0.81%     
==========================================
  Files         110      113       +3     
  Lines       19409    19607     +198     
==========================================
- Hits        11834    11796      -38     
- Misses       6114     6344     +230     
- Partials     1461     1467       +6     
Flag Coverage Δ
apiserver-unittests 33.68% <35.29%> (-0.24%) ⬇️
server-e2e-tests 48.75% <19.79%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cloudprovider/aliyun.go 0.00% <0.00%> (ø)
pkg/cloudprovider/cluster.go 0.00% <0.00%> (ø)
pkg/cloudprovider/terraform.go 0.00% <0.00%> (ø)
pkg/server/config/config.go 0.00% <0.00%> (ø)
pkg/server/domain/service/cluster.go 38.58% <ø> (ø)
pkg/server/infrastructure/clients/kubeclient.go 41.66% <ø> (+0.23%) ⬆️
pkg/server/interfaces/api/dto/v1/types.go 73.33% <ø> (ø)
pkg/server/domain/service/env.go 66.14% <50.00%> (ø)
pkg/server/domain/service/pipeline.go 70.35% <50.00%> (ø)
pkg/server/domain/service/definition.go 72.67% <52.94%> (-2.40%) ⬇️
... and 12 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@chivalryq chivalryq merged commit ff8382c into kubevela:main Jun 26, 2023
12 of 15 checks passed
@chivalryq chivalryq deleted the chore/upgrade-vela-1.9 branch June 26, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants