Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: adds support of mongodb urls with prefix mongodb+srv:// #849

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

NeerajGartia21
Copy link
Collaborator

Fixes #846

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (580372f) 58.90% compared to head (54e2c43) 58.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
- Coverage   58.90%   58.83%   -0.08%     
==========================================
  Files         114      114              
  Lines       19818    19818              
==========================================
- Hits        11673    11659      -14     
- Misses       6704     6714      +10     
- Partials     1441     1445       +4     
Flag Coverage Δ
apiserver-unittests 32.13% <0.00%> (+0.06%) ⬆️
server-e2e-tests 48.23% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...server/infrastructure/datastore/mongodb/mongodb.go 3.66% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chivalryq chivalryq merged commit 118a9fe into kubevela:main Jun 28, 2023
12 of 15 checks passed
@NeerajGartia21 NeerajGartia21 deleted the mongodb_srv_url branch June 28, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MongoDB driver doesn't support connection string URI with mongodb+srv:// prefix.
2 participants