Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: customized uiSchema can't show properly #854

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

mujinhuakai
Copy link
Contributor

Description of your changes

the two group of properties ,as show in the picture, can't coexist
image
otherwise it will has an error when deploy app
image
So, we customized the uiSchema as follows
image
But the customized uiSchema can't show properly

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: liyanfang <liyanfang@cmss.chinamobile.com>
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (118a9fe) 58.80% compared to head (ca57d5e) 58.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   58.80%   58.86%   +0.05%     
==========================================
  Files         114      114              
  Lines       19818    19818              
==========================================
+ Hits        11654    11665      +11     
+ Misses       6718     6710       -8     
+ Partials     1446     1443       -3     
Flag Coverage Δ
apiserver-unittests 32.19% <ø> (+0.11%) ⬆️
server-e2e-tests 48.23% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chivalryq chivalryq merged commit 8a81aa1 into kubevela:main Jul 14, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants