Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: applied default cluster to created target #857

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

zuoningz
Copy link
Contributor

@zuoningz zuoningz commented Jul 17, 2023

Description of your changes

In CreateTarget, a default cluster should be created if cluster is not speicified in the request. However, cluster is only applied to the request variable, not the actual created target . With this fix, the created target would have default cluster

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (8a81aa1) 58.79% compared to head (9ec82ca) 58.89%.

❗ Current head 9ec82ca differs from pull request most recent head 197224d. Consider uploading reports for the commit 197224d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
+ Coverage   58.79%   58.89%   +0.09%     
==========================================
  Files         114      114              
  Lines       19822    19822              
==========================================
+ Hits        11655    11674      +19     
+ Misses       6720     6706      -14     
+ Partials     1447     1442       -5     
Flag Coverage Δ
apiserver-unittests 32.05% <100.00%> (-0.02%) ⬇️
server-e2e-tests 48.37% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/domain/service/target.go 56.66% <100.00%> (-1.67%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Z Zhang <zuoning@AndrewZs-MacBook-Air.local>
@chivalryq chivalryq merged commit 0e56cec into kubevela:main Jul 18, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants