Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CodeQL job fails #860

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Fix: CodeQL job fails #860

merged 4 commits into from
Jul 21, 2023

Conversation

chivalryq
Copy link
Member

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 43.67% and project coverage change: +0.03 🎉

Comparison is base (28dea8a) 58.89% compared to head (7915fba) 58.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
+ Coverage   58.89%   58.93%   +0.03%     
==========================================
  Files         114      114              
  Lines       19822    19795      -27     
==========================================
- Hits        11675    11667       -8     
+ Misses       6705     6691      -14     
+ Partials     1442     1437       -5     
Flag Coverage Δ
apiserver-unittests 32.12% <34.11%> (-0.05%) ⬇️
server-e2e-tests 48.40% <32.18%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/plugin/proxy/static_server_proxy.go 0.00% <0.00%> (ø)
pkg/plugin/types/plugin.go 40.00% <ø> (ø)
pkg/server/domain/repository/target.go 47.16% <0.00%> (ø)
pkg/server/domain/service/authentication.go 49.13% <0.00%> (ø)
pkg/server/domain/service/cluster.go 38.58% <0.00%> (ø)
pkg/server/domain/service/target.go 56.66% <0.00%> (-1.67%) ⬇️
...rver/infrastructure/datastore/sqlnamer/sqlnamer.go 0.00% <0.00%> (ø)
pkg/server/interfaces/api/dto/v1/types.go 73.33% <ø> (ø)
pkg/server/interfaces/api/workflow.go 18.95% <0.00%> (ø)
pkg/server/server.go 54.54% <0.00%> (ø)
... and 13 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@wangyikewxgm wangyikewxgm merged commit 76a39a7 into kubevela:main Jul 21, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants