Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: additionalPropertis in openapi schema converted to uischema wrongly #861

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented Jul 21, 2023

Description of your changes

The meaning of additionalProperties.has is wrongly used. Then default uischema of gateway is wrongly generated.

Ref: https://swagger.io/docs/specification/data-models/dictionaries/

Fixes kubevela/kubevela#6165

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 ⚠️

Comparison is base (76a39a7) 59.07% compared to head (82767a6) 59.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #861      +/-   ##
==========================================
- Coverage   59.07%   59.03%   -0.05%     
==========================================
  Files         114      114              
  Lines       19795    19795              
==========================================
- Hits        11693    11685       -8     
- Misses       6673     6677       +4     
- Partials     1429     1433       +4     
Flag Coverage Δ
apiserver-unittests 32.20% <0.00%> (+0.03%) ⬆️
server-e2e-tests 48.43% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/domain/service/definition.go 74.59% <100.00%> (+1.91%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wonderflow wonderflow merged commit 3978079 into kubevela:main Jul 22, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

velaux 1.9.1 Configure the gateway, and convert the port into a string
3 participants