Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: incorrect API response mark #864

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

zuoningz
Copy link
Contributor

@zuoningz zuoningz commented Jul 27, 2023

Description of your changes

Some API have returns200 in the response, which would overwrite the desired API response format with a SimpleResponse object, which is a bug on the server side. This MR removes the returns200 field so that each API response will respond data in the wanted format

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Z Zhang added 2 commits July 26, 2023 22:41
Signed-off-by: Z Zhang <zuoning@AndrewZs-MacBook-Air.local>
Signed-off-by: Z Zhang <zuoning@AndrewZs-MacBook-Air.local>
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 91.89% and project coverage change: -10.76% ⚠️

Comparison is base (3978079) 59.05% compared to head (71bcb4b) 48.29%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #864       +/-   ##
===========================================
- Coverage   59.05%   48.29%   -10.76%     
===========================================
  Files         114      114               
  Lines       19795    19801        +6     
===========================================
- Hits        11690     9563     -2127     
- Misses       6674     8990     +2316     
+ Partials     1431     1248      -183     
Flag Coverage Δ
apiserver-unittests ?
server-e2e-tests 48.29% <91.89%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/server/interfaces/api/application.go 61.30% <70.00%> (-0.18%) ⬇️
pkg/server/interfaces/api/cloudshell.go 48.30% <100.00%> (-1.29%) ⬇️
pkg/server/interfaces/api/cluster.go 46.70% <100.00%> (ø)
pkg/server/interfaces/api/definition.go 62.20% <100.00%> (ø)
pkg/server/interfaces/api/plugin.go 55.27% <100.00%> (+1.87%) ⬆️
pkg/server/interfaces/api/target.go 40.38% <100.00%> (-0.38%) ⬇️

... and 45 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chivalryq chivalryq changed the title Bug/incomplete response Fix: incorrect API response mark Jul 27, 2023
Signed-off-by: Z Zhang <zuoning@AndrewZs-MacBook-Air.local>
Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chivalryq chivalryq merged commit d0b2a3b into kubevela:main Jul 27, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants