-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: incorrect API response mark #864
Conversation
Signed-off-by: Z Zhang <zuoning@AndrewZs-MacBook-Air.local>
Signed-off-by: Z Zhang <zuoning@AndrewZs-MacBook-Air.local>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #864 +/- ##
===========================================
- Coverage 59.05% 48.29% -10.76%
===========================================
Files 114 114
Lines 19795 19801 +6
===========================================
- Hits 11690 9563 -2127
- Misses 6674 8990 +2316
+ Partials 1431 1248 -183
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Z Zhang <zuoning@AndrewZs-MacBook-Air.local>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of your changes
Some API have returns200 in the response, which would overwrite the desired API response format with a SimpleResponse object, which is a bug on the server side. This MR removes the
returns200
field so that each API response will respond data in the wanted formatFixes #
I have:
yarn lint
to ensure the frontend changes are ready for review.make reviewable
to ensure the server changes are ready for review.backport release-x.y
labels to auto-backport this PR if necessary.Special notes for your reviewer