Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fail to get global helm config secret #867

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented Aug 2, 2023

Signed-off-by: Qiaozp qiaozhongpei.qzp@alibaba-inc.com

Description of your changes

The logic in GetConfig interface will return extract auth info from secret error when the configured helm repo is from global config.

image

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@chivalryq chivalryq changed the title Fix: fail to get global config when config not exist in project scope Fix: fail to get global helm config secret Aug 2, 2023
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 83.87% and project coverage change: -0.66% ⚠️

Comparison is base (3978079) 59.05% compared to head (96e3596) 58.39%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   59.05%   58.39%   -0.66%     
==========================================
  Files         114      115       +1     
  Lines       19795    20039     +244     
==========================================
+ Hits        11690    11702      +12     
- Misses       6674     6901     +227     
- Partials     1431     1436       +5     
Flag Coverage Δ
apiserver-unittests 31.87% <67.74%> (-0.30%) ⬇️
server-e2e-tests 47.81% <58.06%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/server/domain/service/helm.go 49.60% <66.66%> (+0.39%) ⬆️
pkg/server/domain/service/config.go 64.06% <85.71%> (+1.66%) ⬆️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@chivalryq chivalryq merged commit 8438aa7 into kubevela:main Aug 2, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants