Skip to content

Commit

Permalink
Fix: fix the step group status if there's a suspending sub step (#158)
Browse files Browse the repository at this point in the history
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
  • Loading branch information
FogDong committed Apr 12, 2023
1 parent 9c36c21 commit be9e5a1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/tasks/builtin/step_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,12 @@ func getStepGroupStatus(status v1alpha1.StepStatus, stepStatus v1alpha1.Workflow
return status, &types.Operation{Skip: true}
case status.Phase == v1alpha1.WorkflowStepPhaseFailed && status.Reason == types.StatusReasonTimeout:
return status, &types.Operation{Terminated: true}
case subStepCounts[string(v1alpha1.WorkflowStepPhaseSuspending)] > 0:
status.Phase = v1alpha1.WorkflowStepPhaseSuspending
case len(stepStatus.SubStepsStatus) < subTaskRunners:
status.Phase = v1alpha1.WorkflowStepPhaseRunning
case subStepCounts[string(v1alpha1.WorkflowStepPhaseRunning)] > 0:
status.Phase = v1alpha1.WorkflowStepPhaseRunning
case subStepCounts[string(v1alpha1.WorkflowStepPhaseSuspending)] > 0:
status.Phase = v1alpha1.WorkflowStepPhaseSuspending
case subStepCounts[string(v1alpha1.WorkflowStepPhasePending)] > 0:
status.Phase = v1alpha1.WorkflowStepPhasePending
case subStepCounts[string(v1alpha1.WorkflowStepPhaseFailed)] > 0:
Expand Down

0 comments on commit be9e5a1

Please sign in to comment.