Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add cache handle if the patch is failed in end reconcile #113

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Jan 3, 2023

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 68.38% // Head: 65.23% // Decreases project coverage by -3.14% ⚠️

Coverage data is based on head (5832523) compared to base (6ae0c5c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   68.38%   65.23%   -3.15%     
==========================================
  Files          49       41       -8     
  Lines        4314     4220      -94     
==========================================
- Hits         2950     2753     -197     
- Misses       1003     1103     +100     
- Partials      361      364       +3     
Flag Coverage Δ
e2etests ?
unit-test 65.23% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/workflowrun_controller.go 56.39% <0.00%> (-23.92%) ⬇️
pkg/tasks/discover.go 56.25% <0.00%> (-37.50%) ⬇️
...g/webhook/v1alpha1/workflowrun/mutating_handler.go 58.82% <0.00%> (-17.65%) ⬇️
api/condition/condition.go 85.71% <0.00%> (-14.29%) ⬇️
pkg/providers/config/config.go 57.62% <0.00%> (-13.56%) ⬇️
pkg/providers/workspace/workspace.go 71.66% <0.00%> (-13.34%) ⬇️
pkg/providers/kube/handle.go 48.73% <0.00%> (-10.76%) ⬇️
pkg/tasks/template/load.go 67.56% <0.00%> (-8.11%) ⬇️
...webhook/v1alpha1/workflowrun/validating_handler.go 74.07% <0.00%> (-7.41%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FogDong FogDong merged commit 6124a96 into kubevela:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants