Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: export inputItem and outputItem #125

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented Feb 2, 2023

Signed-off-by: Qiaozp qiaozhongpei.qzp@alibaba-inc.com

Description of your changes

Export inputItem and outputItem for iterating the StepInputs/Outputs array.

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please meet the lint check.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 65.13% // Head: 67.49% // Increases project coverage by +2.36% 🎉

Coverage data is based on head (d1a466e) compared to base (e8f00ce).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   65.13%   67.49%   +2.36%     
==========================================
  Files          41       49       +8     
  Lines        4228     4323      +95     
==========================================
+ Hits         2754     2918     +164     
+ Misses       1108     1036      -72     
- Partials      366      369       +3     
Flag Coverage Δ
e2etests 24.42% <0.00%> (?)
unit-test 65.13% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/types.go 0.00% <ø> (ø)
pkg/executor/workflow.go 79.59% <33.33%> (+0.67%) ⬆️
api/v1alpha1/register.go 100.00% <0.00%> (ø)
pkg/features/controller_features.go 100.00% <0.00%> (ø)
pkg/webhook/register.go 100.00% <0.00%> (ø)
pkg/monitor/metrics/workflow.go 0.00% <0.00%> (ø)
version/version.go 0.00% <0.00%> (ø)
pkg/monitor/watcher/workflow.go 96.15% <0.00%> (ø)
pkg/types/types.go 33.33% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@chivalryq
Copy link
Member Author

ping @FogDong

@FogDong FogDong merged commit 953a71c into kubevela:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants