Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support resume a specific suspend step in workflow #133

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Feb 10, 2023

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Description of your changes

support resume a specific suspend step in workflow

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 65.00% // Head: 68.12% // Increases project coverage by +3.11% 🎉

Coverage data is based on head (3cfc66b) compared to base (2daa3cb).
Patch coverage: 73.17% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   65.00%   68.12%   +3.11%     
==========================================
  Files          40       48       +8     
  Lines        4184     4311     +127     
==========================================
+ Hits         2720     2937     +217     
+ Misses       1106     1015      -91     
- Partials      358      359       +1     
Flag Coverage Δ
e2etests 25.19% <ø> (?)
unit-test 65.08% <73.17%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cue/model/sets/operation.go 74.38% <ø> (ø)
pkg/utils/operation.go 77.91% <73.17%> (-0.45%) ⬇️
pkg/webhook/register.go 100.00% <0.00%> (ø)
api/v1alpha1/types.go 11.11% <0.00%> (ø)
pkg/types/types.go 33.33% <0.00%> (ø)
version/version.go 0.00% <0.00%> (ø)
pkg/monitor/watcher/workflow.go 96.15% <0.00%> (ø)
pkg/features/controller_features.go 100.00% <0.00%> (ø)
api/v1alpha1/register.go 100.00% <0.00%> (ø)
pkg/monitor/metrics/workflow.go 0.00% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/utils/operation.go Outdated Show resolved Hide resolved
Copy link
Contributor

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in which case shall we need to specify the step?

@FogDong
Copy link
Member Author

FogDong commented Feb 13, 2023

in which case shall we need to specify the step?

eg.

mode:
    steps: DAG
    subSteps: StepByStep
steps:
    - name:  deploy1
       type: step-group
       subSteps:
           - name: deploy1-test
              type: deploy
           - name: deploy1-suspend
              type: suspend
           - name: deploy1-prod
              type: deploy
    - name:  deploy2
       type: step-group
       subSteps:
           - name: deploy2-test
              type: deploy
           - name: deploy2-suspend
              type: suspend
           - name: deploy2-prod
              type: deploy

There's case that deploy1-suspend and deploy2-suspend is both suspending, and users only want to resume one of them but not the whole workflow.

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong merged commit 92d7b6a into kubevela:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants