Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support multi suspend in definition and fix resume #139

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Feb 23, 2023

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 67.40% // Head: 68.26% // Increases project coverage by +0.85% 🎉

Coverage data is based on head (4304689) compared to base (ecaf98d).
Patch coverage: 76.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   67.40%   68.26%   +0.85%     
==========================================
  Files          47       47              
  Lines        4283     4336      +53     
==========================================
+ Hits         2887     2960      +73     
+ Misses       1024     1004      -20     
  Partials      372      372              
Flag Coverage Δ
e2etests 25.51% <56.00%> (+1.20%) ⬆️
unit-test 65.19% <76.38%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/types.go 33.33% <ø> (ø)
pkg/providers/workspace/workspace.go 78.88% <25.00%> (-2.51%) ⬇️
pkg/tasks/custom/task.go 69.61% <70.00%> (-0.54%) ⬇️
pkg/cue/model/value/value.go 76.63% <72.72%> (-0.11%) ⬇️
pkg/utils/operation.go 78.10% <82.97%> (+0.18%) ⬆️
pkg/executor/workflow.go 81.33% <0.00%> (+1.77%) ⬆️
pkg/context/context.go 74.83% <0.00%> (+3.31%) ⬆️
api/condition/condition.go 100.00% <0.00%> (+7.79%) ⬆️
api/v1alpha1/types.go 11.11% <0.00%> (+11.11%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong merged commit 1a2e8a1 into kubevela:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants