Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add recycle grouped workflow run with cron #143

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Mar 1, 2023

Description of your changes

Add recycle grouped workflow run with cron.

The recycle function will be executed at 0 am every day. By default, if a group of workflows have the same label like pipeline.oam.dev/name , and all of them had been completed for a month, only the latest one is kept, and the others will be recycled.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 55.73% and project coverage change: +0.70 🎉

Comparison is base (8eae143) 67.49% compared to head (d6d728a) 68.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   67.49%   68.19%   +0.70%     
==========================================
  Files          47       48       +1     
  Lines        4341     4399      +58     
==========================================
+ Hits         2930     3000      +70     
+ Misses       1031     1019      -12     
  Partials      380      380              
Flag Coverage Δ
e2etests 23.22% <26.92%> (-1.15%) ⬇️
unit-test 65.17% <55.73%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/main.go 0.93% <0.00%> (-0.03%) ⬇️
pkg/utils/recycle.go 65.38% <65.38%> (ø)
pkg/executor/workflow.go 81.33% <0.00%> (+1.77%) ⬆️
pkg/context/context.go 74.83% <0.00%> (+3.31%) ⬆️
api/condition/condition.go 100.00% <0.00%> (+7.79%) ⬆️
api/v1alpha1/types.go 11.11% <0.00%> (+11.11%) ⬆️
controllers/workflowrun_controller.go 74.82% <0.00%> (+11.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/main.go Outdated Show resolved Hide resolved
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong merged commit 3420e6d into kubevela:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants