Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: prometheus check steps provider #149

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

wangyikewxgm
Copy link
Contributor

@wangyikewxgm wangyikewxgm commented Mar 21, 2023

prometheus check steps provider.

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

small fix

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

small fix

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

refactor some code

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

add tests

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 35.92% and project coverage change: -1.30 ⚠️

Comparison is base (edc7849) 67.97% compared to head (c79977e) 66.68%.

❗ Current head c79977e differs from pull request most recent head ed5dbf2. Consider uploading reports for the commit ed5dbf2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   67.97%   66.68%   -1.30%     
==========================================
  Files          48       49       +1     
  Lines        4334     4505     +171     
==========================================
+ Hits         2946     3004      +58     
- Misses       1022     1099      +77     
- Partials      366      402      +36     
Flag Coverage Δ
e2etests 21.80% <4.85%> (-3.26%) ⬇️
unit-test 64.42% <32.03%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/providers/metrics/prom_check.go 35.29% <35.29%> (ø)
pkg/generator/generator.go 68.80% <100.00%> (+0.25%) ⬆️

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

small fix

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

small fix

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@wangyikewxgm wangyikewxgm force-pushed the check-metrics branch 2 times, most recently from da9544b to 27c3c61 Compare March 27, 2023 05:55
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

small fix

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

delete useless code

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

add nolint

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

small fix

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

small fix

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix comments

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>

fix comments

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@FogDong FogDong merged commit c730c05 into kubevela:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants