Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the opt #157

Closed
wants to merge 2 commits into from
Closed

refactor the opt #157

wants to merge 2 commits into from

Conversation

mouuii
Copy link

@mouuii mouuii commented Apr 7, 2023

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: mouuii <49775493+mouuii@users.noreply.github.com>
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though you want to pass parameters via options, the fields in the StepGeneratorOptions are still exported to users. It seems useless since the options do not limit the usage of the field in the struct.

Signed-off-by: mouuii <49775493+mouuii@users.noreply.github.com>
@mouuii
Copy link
Author

mouuii commented Apr 7, 2023

Though you want to pass parameters via options, the fields in the StepGeneratorOptions are still exported to users. It seems useless since the options do not limit the usage of the field in the struct.

changed to lower case

@mouuii
Copy link
Author

mouuii commented Apr 7, 2023

or we can split the types file into multi files

@mouuii mouuii closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants