Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add image pull secret in task step #166

Merged
merged 1 commit into from
May 29, 2023
Merged

Conversation

Arvintian
Copy link
Contributor

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Have run task in my local cluster with private registry.

Special notes for your reviewer

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.70 🎉

Comparison is base (34c6911) 66.85% compared to head (021c79b) 67.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   66.85%   67.56%   +0.70%     
==========================================
  Files          50       50              
  Lines        4547     4547              
==========================================
+ Hits         3040     3072      +32     
+ Misses       1102     1077      -25     
+ Partials      405      398       -7     
Flag Coverage Δ
e2etests 23.05% <ø> (+0.87%) ⬆️
unit-test 64.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Arvintian Arvintian force-pushed the main branch 2 times, most recently from 0e1146b to f371d95 Compare May 25, 2023 04:20
Copy link
Contributor

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep using the same indent.

Signed-off-by: Arvin <arvintian8@gmail.com>
@FogDong FogDong merged commit 97c5853 into kubevela:main May 29, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants