Skip to content

Commit

Permalink
Bug 2175983: Update text on Delete modal for bootable volumes
Browse files Browse the repository at this point in the history
Update the title and the text of the Delete modal for bootable volumes:

Modal title text: "Delete volume parameters?"

Modal content: "Deleting the parameters will mark this volume
as non-bootable and remove it from the bootable volumes list.
The volume will still be available in the cluster.Are you sure you want
to delete the parameters from bootable volume <volume_name>?"

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2175983
  • Loading branch information
hstastna committed Mar 15, 2023
1 parent d59a7ad commit 54c337c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions locales/en/plugin__kubevirt-plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,6 @@
"Delete DataImportCron?": "Delete DataImportCron?",
"Delete DataSource?": "Delete DataSource?",
"Delete disks ({{diskCount}}x)": "Delete disks ({{diskCount}}x)",
"Delete labels?": "Delete labels?",
"Delete MigrationPolicy?": "Delete MigrationPolicy?",
"Delete NIC?": "Delete NIC?",
"Delete Resource?": "Delete Resource?",
Expand All @@ -338,6 +337,8 @@
"Delete VirtualMachineInstance": "Delete VirtualMachineInstance",
"Delete VirtualMachineInstance?": "Delete VirtualMachineInstance?",
"Delete VirtualMachineSnapshot?": "Delete VirtualMachineSnapshot?",
"Delete volume parameters?": "Delete volume parameters?",
"Deleting the parameters will mark this volume as non-bootable and remove it from the bootable volumes list. The volume will still be available in the cluster. Are you sure you want to delete the parameters from bootable volume <2>{dataSource?.metadata?.name}</2>?": "Deleting the parameters will mark this volume as non-bootable and remove it from the bootable volumes list. The volume will still be available in the cluster. Are you sure you want to delete the parameters from bootable volume <2>{dataSource?.metadata?.name}</2>?",
"Deprecated": "Deprecated",
"Descheduler": "Descheduler",
"Descheduler settings": "Descheduler settings",
Expand Down Expand Up @@ -740,7 +741,6 @@
"Please do not close this window, you can keep navigating the app freely.": "Please do not close this window, you can keep navigating the app freely.",
"Please don't close this browser tab": "Please don't close this browser tab",
"Please don’t close this browser tab": "Please don’t close this browser tab",
"Please note that only the labels data will be deleted and that the bootable volume will remain. Are you sure you want to delete the labels for bootable volume <2>{dataSource?.metadata?.name}</2>?": "Please note that only the labels data will be deleted and that the bootable volume will remain. Are you sure you want to delete the labels for bootable volume <2>{dataSource?.metadata?.name}</2>?",
"Please provide hostname.": "Please provide hostname.",
"Please select a boot source": "Please select a boot source",
"Please wait, once the Data Volume has been created the data will start uploading into this Persistent Volume Claims.": "Please wait, once the Data Volume has been created the data will start uploading into this Persistent Volume Claims.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,13 @@ const DeleteBootableVolumesModal: FC<DeleteBootableVolumesModalProps> = ({
obj={dataSource}
isOpen={isOpen}
onClose={onClose}
headerText={t('Delete labels?')}
headerText={t('Delete volume parameters?')}
onDeleteSubmit={deleteBootableVolumeMetadata(dataSource)}
bodyText={
<Trans t={t}>
Please note that only the labels data will be deleted and that the bootable volume will
remain. Are you sure you want to delete the labels for bootable volume{' '}
Deleting the parameters will mark this volume as non-bootable and remove it from the
bootable volumes list. The volume will still be available in the cluster. Are you sure you
want to delete the parameters from bootable volume{' '}
<strong>{dataSource?.metadata?.name}</strong>?
</Trans>
}
Expand Down

0 comments on commit 54c337c

Please sign in to comment.