Skip to content

Commit

Permalink
Merge pull request #635 from pcbailey/hide-details-card-for-nonadmins
Browse files Browse the repository at this point in the history
Bug 2092781: Hide the details card for non-admins
  • Loading branch information
openshift-ci[bot] committed Jun 16, 2022
2 parents e0ef63f + 297c16d commit 68ad2c2
Showing 1 changed file with 32 additions and 28 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as React from 'react';

import { useIsAdmin } from '@kubevirt-utils/hooks/useIsAdmin';
import { useKubevirtTranslation } from '@kubevirt-utils/hooks/useKubevirtTranslation';
import { DetailsBody } from '@openshift-console/dynamic-plugin-sdk-internal';
import { OverviewDetailItem } from '@openshift-console/plugin-shared';
Expand All @@ -11,6 +12,7 @@ import SubscriptionStatus from './SourceMissingStatus/SubscriptionStatus';

const DetailsCard: React.FC = () => {
const { t } = useKubevirtTranslation();
const isAdmin = useIsAdmin();
const kvCsvDetails = useKubevirtCSVDetails();
const {
name,
Expand All @@ -25,34 +27,36 @@ const DetailsCard: React.FC = () => {
const isLoading = !loaded && !loadError && !kubevirtSub;

return (
<Card data-test-id="kubevirt-overview-dashboard--details-card">
<CardHeader>
<CardTitle>{t('Details')}</CardTitle>
</CardHeader>
<CardBody>
<DetailsBody>
<OverviewDetailItem isLoading={isLoading} title={t('Service name')}>
{name}
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('Provider')}>
{provider}
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('OpenShift Virtualization version')}>
{version}
<div>
{catalogSourceMissing ? (
<SourceMissingStatus />
) : (
<SubscriptionStatus subscription={kubevirtSub} />
)}
</div>
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('Update Channel')}>
{updateChannel}
</OverviewDetailItem>
</DetailsBody>
</CardBody>
</Card>
isAdmin && (
<Card data-test-id="kubevirt-overview-dashboard--details-card">
<CardHeader>
<CardTitle>{t('Details')}</CardTitle>
</CardHeader>
<CardBody>
<DetailsBody>
<OverviewDetailItem isLoading={isLoading} title={t('Service name')}>
{name}
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('Provider')}>
{provider}
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('OpenShift Virtualization version')}>
{version}
<div>
{catalogSourceMissing ? (
<SourceMissingStatus />
) : (
<SubscriptionStatus subscription={kubevirtSub} />
)}
</div>
</OverviewDetailItem>
<OverviewDetailItem isLoading={isLoading} title={t('Update Channel')}>
{updateChannel}
</OverviewDetailItem>
</DetailsBody>
</CardBody>
</Card>
)
);
};

Expand Down

0 comments on commit 68ad2c2

Please sign in to comment.