Merge pull request #685 from upalatucci/template-no-optional-parameters

Bug 2101430: Fix customize form crash
kubevirt-ui · Jun 29, 2022 · 88bac06 · 88bac06
2 parents 322e02b + 2b86527
commit 88bac06
Showing 1 changed file with 19 additions and 18 deletions.
diff --git a/src/views/catalog/customize/components/ExpandableOptionalFields.tsx b/src/views/catalog/customize/components/ExpandableOptionalFields.tsx
@@ -18,22 +18,23 @@ export const ExpandableOptionsFields: React.FC<ExpandableOptionsFieldsProps> = (
   const { t } = useKubevirtTranslation();
   const [optionalFieldsExpanded, setOptionalFieldsExpanded] = React.useState(false);
 
-  if (optionalFields && optionalFields.length > 0)
-    return (
-      <ExpandableSection
-        toggleText={t('Optional parameters')}
-        data-test-id="expandable-optional-section"
-        onToggle={() => setOptionalFieldsExpanded(!optionalFieldsExpanded)}
-        isExpanded={optionalFieldsExpanded}
-        isIndented
-      >
-        {optionalFields?.map((field) => (
-          <FieldGroup
-            key={field.name}
-            field={field}
-            className="expandable-section-content-margin-top"
-          />
-        ))}
-      </ExpandableSection>
-    );
+  if (!optionalFields || optionalFields.length === 0) return null;
+
+  return (
+    <ExpandableSection
+      toggleText={t('Optional parameters')}
+      data-test-id="expandable-optional-section"
+      onToggle={() => setOptionalFieldsExpanded(!optionalFieldsExpanded)}
+      isExpanded={optionalFieldsExpanded}
+      isIndented
+    >
+      {optionalFields?.map((field) => (
+        <FieldGroup
+          key={field.name}
+          field={field}
+          className="expandable-section-content-margin-top"
+        />
+      ))}
+    </ExpandableSection>
+  );
 };