Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] Bug 2168486: Enable Restore template settings by fixing templates link #1187

Conversation

openshift-cherrypick-robot
Copy link
Collaborator

This is an automated cherry-pick of #1106

/assign hstastna

Make "Restore template settings" enabled, when editing VM's CPU/Memory,
by fixing incorrect link to the original Template the VM was created
from. Fix the incorrect namespace in the link, which was set to the
namespace of the VM when creating a VM, not the original Template's one.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2168486
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: An error was encountered translating bugzilla components to jira components for bug 2168486 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. No mapping from bz component User Experience to a jira component found

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #1106

/assign hstastna

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a kubevirt-ui member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna
Copy link
Member

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@hstastna
Copy link
Member

@hstastna
Copy link
Member

/approve

@hstastna
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Mar 23, 2023
@tnisan
Copy link
Member

tnisan commented Mar 23, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, openshift-cherrypick-robot, tnisan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Mar 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit c2dd68e into kubevirt-ui:release-4.12 Mar 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

@openshift-cherrypick-robot: Bugzilla bug 2168486 is in an unrecognized state (VERIFIED) and will not be moved to the MODIFIED state.

In response to this:

[release-4.12] Bug 2168486: Enable Restore template settings by fixing templates link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge needs-ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants