Bug 2181432: fix unreachable instancetype in vm details #1198
Conversation
|
@upalatucci: This pull request references Bugzilla bug 2181432, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
upalatucci
force-pushed
the
vm-memory-isntancetype
branch
from
8f6a7ab
to
16b50bf
Compare
|
@upalatucci: An error was encountered querying GitHub for users with public email (gouyang@redhat.com) for bug 2181432 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -227,7 +227,11 @@ const VirtualMachineDetailsLeftGrid: React.FC<VirtualMachineDetailsLeftGridProps | |||
| 'CPU and Memory can not be edited if the VirtualMachine is created from InstanceType', | |||
| )} | |||
| isPopover | |||
| bodyContent={<CPUDescription cpu={vm?.spec?.template?.spec?.domain?.cpu} />} | |||
| bodyContent={ | |||
| vm?.spec?.instancetype ? null : ( | |||
There was a problem hiding this comment.
vm?.spec?.instancetype &&
can work? or false be as content?
There was a problem hiding this comment.
Does not work. If bodyContent is false it raises an exception. I can fix VirtualMachineDescriptionItem prop to ignore bodyContent if its false but i don't know if it's worth it
There was a problem hiding this comment.
its not really critical :) at least for now
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@upalatucci: All pull requests linked via external trackers have merged: Bugzilla bug 2181432 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.13 |
|
@gouyang: new pull request created: #1209 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
馃摑 Description
Handle vm instance type error.
For non-priv user the instance-type can be unreachable
Fix also the Operating System and Hostname error handling.
If
useK8sWatchResourceraise an error, theloadedvariable remain false.