Bug 2182317: Restore vm's pretty names #1199
Conversation
openshift-ci
bot
added
bugzilla/severity-unspecified
approved
|
@metalice: This pull request references Bugzilla bug 2182317, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
metalice
force-pushed
the
bz-2182317-retore-pretty-name-vm
branch
from
7c639b5
to
f967f07
Compare
| React.useEffect(() => { | ||
| setLoaded(false); | ||
|
|
||
| if (template) { | ||
| const [nameParam, ...restParams] = template?.parameters; |
There was a problem hiding this comment.
is this guaranteed that the first element is always the name?
There was a problem hiding this comment.
Usually, it first from common templates, but u are right, it's definitely not guaranteed. fixed, nice catch
metalice
force-pushed
the
bz-2182317-retore-pretty-name-vm
branch
from
f967f07
to
170e8ac
Compare
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
metalice
force-pushed
the
bz-2182317-retore-pretty-name-vm
branch
from
170e8ac
to
fad61ff
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@metalice: All pull requests linked via external trackers have merged: Bugzilla bug 2182317 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.13 |
|
@gouyang: new pull request created: #1210 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
馃摑 Description
A new request of restoring VM pretty names and ignoring name param of the template if annotation openshift.kubevirt.io/pronounceable-suffix-for-name-expression: true is presented in the template
馃帴 Demo