Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2182000: Display VM Metrics graphs with Y-Axis #1250

Conversation

hstastna
Copy link
Member

馃摑 Description

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2182000

Display Memory, CPU and Network graphs consistently with Storage graphs, in VM Metrics tab:
show missing y-axis for those graphs.

馃帴 Screenshots

Before:
No y-axis for Memory, CPU and Network graphs :
before

After:
Y-axis present in Memory, CPU and Network graphs, same as in Storage graphs:
after

Display Memory, CPU and Network graphs consistently with Storage graphs,
in VM Metrics tab: show missing y-axis for those graphs.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2182000
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

@hstastna: This pull request references Bugzilla bug 2182000, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lkladnit

In response to this:

Bug 2182000: Display VM Metrics graphs with Y-Axis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: lkladnit.

Note that only kubevirt-ui members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@hstastna: This pull request references Bugzilla bug 2182000, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lkladnit

In response to this:

Bug 2182000: Display VM Metrics graphs with Y-Axis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna
Copy link
Member Author

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hstastna,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f61cb51 into kubevirt-ui:main Apr 14, 2023
4 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2023

@hstastna: All pull requests linked via external trackers have merged:

Bugzilla bug 2182000 has been moved to the MODIFIED state.

In response to this:

Bug 2182000: Display VM Metrics graphs with Y-Axis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hstastna
Copy link
Member Author

/cherrypick release-4.13

@openshift-cherrypick-robot
Copy link
Collaborator

@hstastna: new pull request created: #1252

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-unspecified bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants