Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2183915: "No data available" shows on Virtualization overview metrics chart #1257

Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Apr 17, 2023

📝 Description

  • Changing graphs messages to fit more appropriately in case of not enough data points, This solution was discussed with Ronen
  • Fixing namespaced memory and storage queries

🎥 Demo

Before:

overview-graphs-b4.mp4

After:

overview-graphs.mp4

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 17, 2023

@avivtur: This pull request references Bugzilla bug 2183915, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2183915: "No data available" shows on Virtualization overview metrics chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 17, 2023
@openshift-ci openshift-ci bot requested a review from gouyang April 17, 2023 17:02
@gouyang
Copy link
Member

gouyang commented Apr 17, 2023

/retest

1 similar comment
@gouyang
Copy link
Member

gouyang commented Apr 18, 2023

/retest

@gouyang
Copy link
Member

gouyang commented Apr 18, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avivtur avivtur changed the title Bug 2183915: "No data available" shows on Virtualization overview metrics chart [WIP] Bug 2183915: "No data available" shows on Virtualization overview metrics chart Apr 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

@avivtur: This pull request references Bugzilla bug 2183915, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

[WIP] Bug 2183915: "No data available" shows on Virtualization overview metrics chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

@avivtur: This pull request references Bugzilla bug 2183915, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

[WIP] Bug 2183915: "No data available" shows on Virtualization overview metrics chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…rics chart

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@avivtur avivtur changed the title [WIP] Bug 2183915: "No data available" shows on Virtualization overview metrics chart Bug 2183915: "No data available" shows on Virtualization overview metrics chart Apr 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

@avivtur: This pull request references Bugzilla bug 2183915, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.14.0) matches configured target release for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2183915: "No data available" shows on Virtualization overview metrics chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@avivtur
Copy link
Member Author

avivtur commented Apr 18, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit ed3dfcf into kubevirt-ui:main Apr 18, 2023
8 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 18, 2023

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2183915 has been moved to the MODIFIED state.

In response to this:

Bug 2183915: "No data available" shows on Virtualization overview metrics chart

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@gouyang: new pull request created: #1262

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-high bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants