Bug 2189744: no docker prefix for container image #1277
Conversation
|
@upalatucci: This pull request references Bugzilla bug 2189744, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
upalatucci
force-pushed
the
no-docker-prefix
branch
from
f0212d2
to
5506498
Compare
upalatucci
force-pushed
the
no-docker-prefix
branch
from
5506498
to
d16e41f
Compare
| cdVolume = { | ||
| name: INSTALLATION_CDROM_NAME, | ||
| containerDisk: { | ||
| image: cdSource.source?.registry.url, | ||
| image: removeDockerPrefix((cdSource as V1ContainerDiskSource).image), |
There was a problem hiding this comment.
let's have this removeDockerPrefix in case the user types the prefix anyways.
Here the prefix will cause an error in the VM start.
|
/bugzilla refresh |
|
@upalatucci: This pull request references Bugzilla bug 2189744, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@upalatucci: All pull requests linked via external trackers have merged: Bugzilla bug 2189744 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.13 |
|
@gouyang: new pull request created: #1293 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
馃摑 Description
remove docker prefix when using containerDisk.
ContainerDisk already expect a docker image URL so using
docker://prefix is wrong