Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-28438: cloudInitConfigDrive yaml contains cloudInitNoCloud content #1582

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Oct 9, 2023

馃摑 Description

Moving from cloudDrive to noCloud will solve these issues:
https://issues.redhat.com/browse/CNV-28438
https://issues.redhat.com/browse/CNV-29802
https://issues.redhat.com/browse/CNV-28700

馃帴 Demo

Before:

connect-ssh-with-cloud-init-secondary-network-b4.mp4
cloud-init-cloudDrive.mp4

After:

connect-ssh-with-cloud-init-secondary-network.mp4
cloud-init-noCloud.mp4

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 9, 2023

@avivtur: This pull request references CNV-28438 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

馃摑 Description

Moving from cloudDrive to noCloud will solve these issues:
https://issues.redhat.com/browse/CNV-28438
https://issues.redhat.com/browse/CNV-29802
https://issues.redhat.com/browse/CNV-28700

馃帴 Demo

Before:

connect-ssh-with-cloud-init-secondary-network-b4.mp4
cloud-init-cloudDrive.mp4

After:

connect-ssh-with-cloud-init-secondary-network.mp4
cloud-init-noCloud.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from hstastna and tnisan October 9, 2023 10:52
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Oct 9, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 9, 2023

@avivtur: This pull request references CNV-28438 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

馃摑 Description

Moving from cloudDrive to noCloud will solve these issues:
https://issues.redhat.com/browse/CNV-28438
https://issues.redhat.com/browse/CNV-29802
https://issues.redhat.com/browse/CNV-28700

馃帴 Demo

Before:

connect-ssh-with-cloud-init-secondary-network-b4.mp4
cloud-init-cloudDrive.mp4

After:

connect-ssh-with-cloud-init-secondary-network.mp4
cloud-init-noCloud.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@hstastna hstastna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me some time to watch the videos and to understand the core problems. But now it makes sense to me. Left some question, otherwise 馃憤馃徑 !

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, hstastna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 4c03b2d into kubevirt-ui:main Oct 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants