-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-28438: cloudInitConfigDrive yaml contains cloudInitNoCloud content #1582
Conversation
@avivtur: This pull request references CNV-28438 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@avivtur: This pull request references CNV-28438 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took me some time to watch the videos and to understand the core problems. But now it makes sense to me. Left some question, otherwise 馃憤馃徑 !
b9ec307
to
5662a75
Compare
src/views/catalog/wizard/tabs/scripts/components/DynamicSSHKeyInjectionWizard.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
5662a75
to
266e7f0
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, hstastna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
馃摑 Description
Moving from cloudDrive to noCloud will solve these issues:
https://issues.redhat.com/browse/CNV-28438
https://issues.redhat.com/browse/CNV-29802
https://issues.redhat.com/browse/CNV-28700
馃帴 Demo
Before:
connect-ssh-with-cloud-init-secondary-network-b4.mp4
cloud-init-cloudDrive.mp4
After:
connect-ssh-with-cloud-init-secondary-network.mp4
cloud-init-noCloud.mp4