Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-32105: Add VM actions icons to the VM details page #1594

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

pcbailey
Copy link
Member

@pcbailey pcbailey commented Oct 29, 2023

馃摑 Description

This PR adds VM action icons to the title bar of the VM details page allowing for easy control of the basic operations of the VM. It also removes the VM actions from the Details card kebab menu.

Jira issue: https://issues.redhat.com/browse/CNV-32105

馃帴 Demo

vm-actions-icons-2023-10-30_14.59.38.mp4

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 29, 2023

@pcbailey: This pull request references CNV-32105 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.15." or "openshift-4.15.", but it targets "CNV v4.15.0" instead.

In response to this:

馃摑 Description

This PR adds VM action icons to the title bar of the VM details page allowing for easy control of the basic operations of the VM. It also removes the VM actions from the Details card kebab menu.

馃帴 Screenshot

vm-action-icons-2023-10-28_23-11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from avivtur and yaacov October 29, 2023 03:41
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Oct 29, 2023
@pcbailey pcbailey changed the title WIP: CNV-32105: Feature VM actions icons WIP: CNV-32105: Add VM actions icons to the VM details page Oct 29, 2023
@apinnick
Copy link

Will this be released with 4.14?

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 29, 2023

@pcbailey: This pull request references CNV-32105 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.15." or "openshift-4.15.", but it targets "CNV v4.15.0" instead.

In response to this:

馃摑 Description

This PR adds VM action icons to the title bar of the VM details page allowing for easy control of the basic operations of the VM. It also removes the VM actions from the Details card kebab menu.

Jira issue: https://issues.redhat.com/browse/CNV-32105

馃帴 Screenshot

vm-action-icons-2023-10-28_23-11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey
Copy link
Member Author

Will this be released with 4.14?

@apinnick No, this is a 4.15 feature.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 30, 2023

@pcbailey: This pull request references CNV-32105 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.15." or "openshift-4.15.", but it targets "CNV v4.15.0" instead.

In response to this:

馃摑 Description

This PR adds VM action icons to the title bar of the VM details page allowing for easy control of the basic operations of the VM. It also removes the VM actions from the Details card kebab menu.

Jira issue: https://issues.redhat.com/browse/CNV-32105

馃帴 Demo

vm-actions-icons-2023-10-30_14.59.38.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey pcbailey changed the title WIP: CNV-32105: Add VM actions icons to the VM details page CNV-32105: Add VM actions icons to the VM details page Oct 30, 2023
@pcbailey
Copy link
Member Author

/retest

@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 4619ef8 into kubevirt-ui:main Oct 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants