-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-32105: Add VM actions icons to the VM details page #1594
CNV-32105: Add VM actions icons to the VM details page #1594
Conversation
@pcbailey: This pull request references CNV-32105 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.15." or "openshift-4.15.", but it targets "CNV v4.15.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Will this be released with 4.14? |
@pcbailey: This pull request references CNV-32105 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.15." or "openshift-4.15.", but it targets "CNV v4.15.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@apinnick No, this is a 4.15 feature. |
c2cb1bd
to
5f5d9ed
Compare
@pcbailey: This pull request references CNV-32105 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.15." or "openshift-4.15.", but it targets "CNV v4.15.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5f5d9ed
to
9c3ac3f
Compare
/retest |
src/views/virtualmachines/details/VirtualMachineNavPageTitle.tsx
Outdated
Show resolved
Hide resolved
9c3ac3f
to
48a1700
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
馃摑 Description
This PR adds VM action icons to the title bar of the VM details page allowing for easy control of the basic operations of the VM. It also removes the VM actions from the Details card kebab menu.
Jira issue: https://issues.redhat.com/browse/CNV-32105
馃帴 Demo
vm-actions-icons-2023-10-30_14.59.38.mp4